Skip to content

chore: add esm dir to git ignore #5180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore: add esm dir to git ignore #5180

wants to merge 1 commit into from

Conversation

@yordis
Copy link
Contributor

@yordis yordis commented May 30, 2022

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

lobsterkatie
lobsterkatie reviewed Jun 1, 2022
View reviewed changes
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are you seeing an esm directory show up and get noticed by git?

@yordis
Copy link
Contributor Author

yordis commented Jun 1, 2022

I ran yarn build command

@lobsterkatie
Copy link
Member

lobsterkatie commented Jun 2, 2022

I ran yarn build command

Are you up to date with current master? The only esm folder not inside a build folder (already ignored) should be the symlink in utils, which is handled by that package's own .gitigore.

@lforst
Copy link
Contributor

lforst commented Jun 2, 2022

I think those files are showing up because we changed our gitignore and you potentially had stale build artifacts before switching branch or pulling. @yordis can you check out master, clean your working tree, then run yarn build again and see what happens?

@yordis
Copy link
Contributor Author

yordis commented Jun 2, 2022

  1. I pull upstream master changes
  2. Deleted all the esm directories
  3. Ran yarn build

Files are gone! My apologies!

@yordis yordis closed this Jun 2, 2022
@yordis yordis deleted the fix-gitignore branch June 2, 2022 16:00
@saidmahamed9605-hue saidmahamed9605-hue mentioned this pull request Oct 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lobsterkatie lobsterkatie lobsterkatie left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yordis @lobsterkatie @lforst